Enable constraints and runtime measurement for Reshape and Mean Ops #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminaleTT
force-pushed
the
arminale/op-models
branch
from
34107c9 to
a318e59
Compare
arminaleTT
added
TTNN Op Perf Model
TTNN Constraints&L1
arminaleTT
requested review from
odjuricicTT,
tt-mpantic,
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
jserbedzijaTT,
jnie-TT and
azecevicTT
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
odjuricicTT
approved these changes
Feb 26, 2025
svuckovicTT
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Hey @arminaleTT, it was a pleasure meeting you in Austin!
The change looks good to me, only commentary I have is on the usage of auto - I've linked to our coding guidelines that cover this topic.
arminaleTT
force-pushed
the
arminale/op-models
branch
from
bd84a76 to
324991c
Compare
arminaleTT
force-pushed
the
arminale/op-models
branch
from
324991c to
1e59ddf
Compare
jserbedzijaTT
pushed a commit
that referenced
this pull request
Mar 1, 2025
…2273) ### Ticket #2041 #2042 ### Problem description To enable llama to go through the optimizer, we need constraints and runtime APIs for all ops (tracked in #2084). This PR enables these APIs for `mean` and `reshape`. ### What's changed - Added `getOpRuntime()` and `getOpConstraints()` interface methods to `ReshapeOp` and `MeanOp` - Added unit tests for both APIs on both Ops - Closes #2041 - Closes #2042 Note: This PR seems long for a "simple" integration change because both APIs require a manual translation of mlir types down to ttnn types. As a result, opportunities for sharing code across Ops is limited. About 1/3rd of the diff is in unit tests ### Checklist - [x] New/Existing tests provide coverage for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#2041
#2042
Problem description
To enable llama to go through the optimizer, we need constraints and runtime APIs for all ops (tracked in #2084). This PR enables these APIs for
meanandreshape.What's changed
getOpRuntime()andgetOpConstraints()interface methods toReshapeOpandMeanOpNote: This PR seems long for a "simple" integration change because both APIs require a manual translation of mlir types down to ttnn types. As a result, opportunities for sharing code across Ops is limited. About 1/3rd of the diff is in unit tests
Checklist